[PATCH] D67819: [LNT] Python 3 support: adapt to zip returning a view

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: lnt/server/reporting/analysis.py:375
         if unchanged_tests:
-            prev_values, run_values, prev_hash, cur_hash = zip(
-                *unchanged_tests)
+            prev_values, run_values, prev_hash, cur_hash = list(zip(
+                *unchanged_tests))
----------------
The unpacking works without this change even in Python 3.


================
Comment at: lnt/tests/nt.py:793
     for row in reader_it:
-        record = dict(zip(header, row))
+        record = dict(list(zip(header, row)))
 
----------------
I believe this change is unnecessary. The constructor will fully visit the result of `zip`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67819/new/

https://reviews.llvm.org/D67819