[PATCH] D67758: [llvm-lipo] Add support for archives

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a subscriber: anushabasana.
smeenai added a comment.

LGTM



================
Comment at: tools/llvm-lipo/llvm-lipo.cpp:246
+    // force arm64-family to follow after all other slices for
+    // compatibility$ with cctools lipo$
+    if (Lhs.CPUType == MachO::CPU_TYPE_ARM64)
----------------
compnerd wrote:
> There are a couple of `$` introduced in the comment.
Still have an `$` here.


================
Comment at: tools/llvm-lipo/llvm-lipo.cpp:161
+
+  // Alignment field to stores slice alignment values from universal
+  // binaries. This is also needed to order the slices so the total
----------------
"to stores" -> "to store"


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67758/new/

https://reviews.llvm.org/D67758