[PATCH] D67758: [llvm-lipo] Add support for archives

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: tools/llvm-lipo/llvm-lipo.cpp:228
+
+  uint32_t getAlignment() const { return Alignment; }
+
----------------
compnerd wrote:
> Can we just make `CPUType`, `CPUSubType, `Alignment` `const` members and make them public?  We can set them properly during the constructor and avoid the unnecessary accessors.
 the thing is that archives those fields should be calculated first (extracted from the members of the archive), thus they can't be const, exposing them as a non-const public doesn't look good to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67758/new/

https://reviews.llvm.org/D67758