[PATCH] D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2.
Sterling Augustine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 20 11:20:10 PDT 2019
saugustine created this revision.
saugustine added reviewers: echristo, arsenm.
Herald added subscribers: llvm-commits, hiraditya, wdng.
Herald added a project: LLVM.
This fixes a crasher introduced by r372338.
Repository:
rL LLVM
https://reviews.llvm.org/D67850
Files:
llvm/lib/Target/X86/X86ISelLowering.cpp
llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
Index: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll
@@ -0,0 +1,12 @@
+; RUN: llc -mtriple=x86_64-linux-gnu - < %s -o -
+
+define void @csrot_(float* %0) #0 {
+1:
+ %2 = load float, float* %0, align 4
+ %3 = fsub float -0.000000e+00, %2
+ %4 = insertelement <2 x float> <float undef, float -0.000000e+00>, float %3, i32 0
+ store <2 x float> %4, <2 x float>* undef, align 8
+ ret void
+}
+
+attributes #0 = { "target-features"="+sse4.2" }
Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -17608,7 +17608,7 @@
// operand form.
N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);
return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1,
- DAG.getConstant(1, dl, MVT::i8));
+ DAG.getTargetConstant(1, dl, MVT::i8));
}
// Create this as a scalar to vector..
N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67850.221077.patch
Type: text/x-patch
Size: 1252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190920/e3c97891/attachment.bin>
More information about the llvm-commits
mailing list