[PATCH] D67777: Improve comments terseness in PassBuilder.h

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Thanks for the cleanup! A couple of small comments inline.



================
Comment at: include/llvm/Passes/PassBuilder.h:73
   /// Constructor sets pipeline tuning defaults based on cl::opts. Each option
   /// can be set in the PassBuilder when using a LLVM as a library.
   PipelineTuningOptions();
----------------
s/a LLVM/LLVM


================
Comment at: include/llvm/Passes/PassBuilder.h:76
 
-  /// Tuning option to set loop interleaving on/off. Its default value is that
+  /// Enables/disables loop interleaving. Its default value is that
   /// of the flag: `-interleave-loops`.
----------------
clang-format all updated comments back to 80.


================
Comment at: include/llvm/Passes/PassBuilder.h:100
+  /// Disables promotion to scalars in LICM with MemorySSA, if
   /// the number of access is too large.
   unsigned LicmMssaNoAccForPromotionCap;
----------------
s/access/accesses (might as well correct my typos while at it :) )


================
Comment at: include/llvm/Passes/PassBuilder.h:130
 
-  /// ThinLTO phase.
-  ///
----------------
Nit: Maybe keep this line and the empty line below, since it's the comment pattern for all the other structs/enums/classes in this class? It's fine either way.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67777/new/

https://reviews.llvm.org/D67777