[PATCH] D67802: [SelectionDAG][Mips][Sparc] Don't allow SimplifyDemandedBits to constant fold TargetConstant nodes to a Constant.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 20 09:41:47 PDT 2019


arsenm added a comment.

In D67802#1676937 <https://reviews.llvm.org/D67802#1676937>, @craig.topper wrote:

> In D67802#1676910 <https://reviews.llvm.org/D67802#1676910>, @arsenm wrote:
>
> > LGTM but could use tests
>
>
> How would you test this? The issues fixed fail existing tests with the llvm_unreachable added to SimplifyDemandedBits.


oh, ok


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67802/new/

https://reviews.llvm.org/D67802





More information about the llvm-commits mailing list