[PATCH] D67785: Use getTargetConstant for BLENDI, and add a test to catch it.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll:3
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-grtev4-linux-gnu"
+
----------------
RKSimon wrote:
> The test file needs a lot of improvement - its missing a RUN line so isn't actually tested, most of the attributes/metadata can probably be ditched, and surely it should be in test/CodeGen/X86/GlobalIsel ?
This belongs in test/CodeGen/X86 (no GlobalISel)


================
Comment at: llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll:14
+
+attributes #0 = { "target-features"="+aes,+cx8,+fxsr,+mmx,+pclmul,+popcnt,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87" }
----------------
Probably don't need most of these


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67785/new/

https://reviews.llvm.org/D67785