[PATCH] D67008: implement parsing relocation information for 32-bit xcoff objectfile

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:140
+    if (Relocations.empty())
+      continue;
+
----------------
DiggerLin wrote:
> sfertile wrote:
> > Your section index will get out of sync, since we continue (to the next section) but don't increment the index.
> index has been increased before W.unindent();
> index has been increased before W.unindent();
Yes, and that line of code will be skipped by the continue for any section that doesn't contain relocations. Any sections following a section with no relocations will be printed with the wrong section index.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67008/new/

https://reviews.llvm.org/D67008