[PATCH] D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/lib/IR/DataLayout.cpp:369
 
-      setAlignment(AlignType, ABIAlign, PrefAlign, Size);
+      if (!isUInt<16>(PrefAlign))
+        report_fatal_error(
----------------
gchatelet wrote:
> courbet wrote:
> > I would move this back to `DataLayout::setAlignment`, or ask for a review to the original authors. They might have had other reasons beyond storage for guarding against this size.
> @majnemer it looks like the checks are only because of implementation details (from 1b9fc3a186aed6ec120688e4d957466f72db3ed5)
> Would it make sense to remove them as well as the tests?
> 
@majnemer I'll submit the code as-is, if you have any concerns please let me know and I can fix it in subsequent patches. Thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67400/new/

https://reviews.llvm.org/D67400