[PATCH] D67785: Use getTargetConstant for BLENDI, and add a test to catch it.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 20 03:54:35 PDT 2019
RKSimon reopened this revision.
RKSimon added reviewers: craig.topper, RKSimon.
RKSimon added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll:3
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-grtev4-linux-gnu"
+
----------------
The test file needs a lot of improvement - its missing a RUN line so isn't actually tested, most of the attributes/metadata can probably be ditched, and surely it should be in test/CodeGen/X86/GlobalIsel ?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67785/new/
https://reviews.llvm.org/D67785
More information about the llvm-commits
mailing list