[PATCH] D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 19:38:36 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/wasm/relocatable.ll:13
 
+
 ; Function Attrs: nounwind
----------------
?


================
Comment at: lld/wasm/SymbolTable.cpp:447
   LLVM_DEBUG(dbgs() << "addUndefinedData: " << name << "\n");
+  assert(flags && WASM_SYMBOL_UNDEFINED);
 
----------------
&& or &


================
Comment at: lld/wasm/SymbolTable.cpp:469
   LLVM_DEBUG(dbgs() << "addUndefinedGlobal: " << name << "\n");
+  assert(flags && WASM_SYMBOL_UNDEFINED);
 
----------------
&& or &


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67729/new/

https://reviews.llvm.org/D67729





More information about the llvm-commits mailing list