[PATCH] D67693: [llvm-objcopy][test] Clean up -B tests

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 19:08:06 PDT 2019


MaskRay added a comment.

In D67693#1675449 <https://reviews.llvm.org/D67693#1675449>, @jakehehrlich wrote:

> To be clear though, we have a test ensuring that -B is ignored, correct?


Yes.

  ELF/binary-input-and-output.test
  21:## -B is ignored.
  22:# RUN: llvm-objcopy -I binary -B i386:x86-64 -O binary %t.txt %t.5.txt
  
  ELF/binary-input-error.test
  3:## -B is ignored.
  4:# RUN: llvm-objcopy -I binary -B xyz %t.txt %t.o
  
  ELF/binary-output-target.test
  77:## In GNU objcopy, e_machine is EM_NONE unless -B is specifid.
  79:## We fill in the field regardless of -B.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67693/new/

https://reviews.llvm.org/D67693





More information about the llvm-commits mailing list