[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 13:56:36 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1739
+void PPCAIXAsmPrinter::EmitFunctionEntryLabel() {
+  return AsmPrinter::EmitFunctionEntryLabel();
+}
----------------
jasonliu wrote:
> Minor nit: we don't need the "return".
I do not believe there is definitive coding standard guidance on this, but when deferring the rest of the control flow and the return value in a function to another function, using `return` is my preference even in the case of returning `void` (if both the caller and callee return `void`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724





More information about the llvm-commits mailing list