[lld] r372351 - Don't false-positive match against binary path.

Mitch Phillips via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 13:44:12 PDT 2019


Author: hctim
Date: Thu Sep 19 13:44:12 2019
New Revision: 372351

URL: http://llvm.org/viewvc/llvm-project?rev=372351&view=rev
Log:
Don't false-positive match against binary path.

copy-rel-abs.s uses llvm-objdump to generate output that's then run
through FileCheck. llvm-objdump prints the file path at the top of the
file, which means that any build path that contains 'zed' will get
false-matched. Ensure that 'zed' is only matched after the 'SYMBOL
TABLE:' output, preventing this from failing if your build directory is
~/build/sanitized-xxx/, or similar.

Modified:
    lld/trunk/test/ELF/copy-rel-abs.s

Modified: lld/trunk/test/ELF/copy-rel-abs.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/copy-rel-abs.s?rev=372351&r1=372350&r2=372351&view=diff
==============================================================================
--- lld/trunk/test/ELF/copy-rel-abs.s (original)
+++ lld/trunk/test/ELF/copy-rel-abs.s Thu Sep 19 13:44:12 2019
@@ -12,11 +12,14 @@
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t2.o
 # RUN: ld.lld %t2.o %t1.so -o %t2
-# RUN: llvm-objdump -t %t2 | FileCheck %s --implicit-check-not=zed
+# RUN: llvm-objdump -t %t2 | FileCheck %s
 
 # CHECK: SYMBOL TABLE:
+# CHECK-NOT: zed
 # CHECK: .bss.rel.ro {{.*}} foo
+# CHECK-NOT: zed
 # CHECK: .bss.rel.ro {{.*}} bar
+# CHECK-NOT: zed
 
 .global _start
 _start:




More information about the llvm-commits mailing list