[PATCH] D67753: [gn build] Fix Python DeprecationWarning

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/utils/gn/build/write_cmake_config.py:65
 
-    in_lines = open(args.input).readlines()
+    with open(args.input) as f:
+        in_lines = f.readlines()
----------------
What warns about this? Python itself?

The garbage collector cleans up the file, and this is a very short-lived script anyways, so I'd prefer brevity over linter happyiness if this is to placate some linter.

If python3 warns about this by default, I suppose it's fine to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67753/new/

https://reviews.llvm.org/D67753