[PATCH] D67761: [ELF] Error if the linked-to section of a SHF_LINK_ORDER section is discarded

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 06:59:42 PDT 2019


grimar added inline comments.


================
Comment at: ELF/Writer.cpp:1527
+              toString(link));
+    }
+    if (errorCount())
----------------
Should we report this much earlier, on GC stage, in MarkLive.cpp for example?

I do not have a chance to check it today unfortunately, but looks it could be done somewhere here:

```
  // Report garbage-collected sections.
  if (config->printGcSections)
    for (InputSectionBase *sec : inputSections)
      if (!sec->isLive())
        message("removing unused section " + toString(sec));
```

?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67761/new/

https://reviews.llvm.org/D67761





More information about the llvm-commits mailing list