[PATCH] D67701: [Unroll] Add an option to control complete unrolling

Wed Sep 18 21:55:08 PDT 2019

fedor.sergeev requested changes to this revision.
fedor.sergeev added a comment.
This revision now requires changes to proceed.

In D67701#1674862 <https://reviews.llvm.org/D67701#1674862>, @fedor.sergeev wrote:

> I might be in need for the morning coffee, but I cant find the actual use of UP.FullUnrollMaxCount...

Ugh... I was looking for that use in the new code, but it is there in the old code, sorry.

So this patch just adds a pass-level option to provide to an existing control.

Looked through the tests and it seems that we have no tests to check this existing control (no use of -unroll-full-max-count option).
Can you, please, extend your test to check:

- for actual "max" functionality, where max is non-zero and trip-count is either more or less than the max
- both ways of controlling this max-count (-passes and direct option)

Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67701/new/

https://reviews.llvm.org/D67701