[PATCH] D67736: [WebAssembly] Sort output data sections to place .bss last

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Nice!



================
Comment at: lld/wasm/Writer.cpp:690
+                     }
+                     llvm_unreachable("Unexpected segment name");
+                   });
----------------
Its possible to have custom segment names.    See Writer.cpp:getOutputDataSegmentName.   Seems strange that no tests use this feature though .. maybe I'm misunderstanding something?

Perhaps just create a partial order that puts bss last?


================
Comment at: lld/wasm/Writer.cpp:695
+    segments[i]->index = i;
+  }
 }
----------------
Drop the curlies for single line blocks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67736/new/

https://reviews.llvm.org/D67736