[PATCH] D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts.

Wed Sep 18 14:21:47 PDT 2019

akhuang marked an inline comment as done.
akhuang added inline comments.

================
Comment at: llvm/test/Bitcode/upgrade-datalayout2.ll:6-7
+
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
rnk wrote:
> You know, it occurs to me that these might be better as unit tests. The prototype of llvm::UpgradeDataLayout takes and returns strings, so it would be really easy to do these in gtest. I think it's actually worth taking the time to do that.
> 
> We might also want to write some negative tests for cases that we don't want to upgrade.
I added a unittest file with some upgrade tests and some negative tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67631/new/

https://reviews.llvm.org/D67631