[PATCH] D67731: Fix arm build failer with libgcc

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz created this revision.
zatrazz added reviewers: echristo, EricWF, saugustine.
zatrazz added a project: LLVM.
Herald added subscribers: libcxx-commits, erik.pilkington, christof, kristof.beyls, mgorny.
Herald added a project: libc++.
zatrazz abandoned this revision.

Both arm32 armv7/armv8 bots are failing to build due to a linking
issue:

[100%] Built target cxxabi_static
CMakeFiles/cxxabi_shared.dir/cxa_demangle.cpp.o: In function `(anonymous namespace)::itanium_demangle::OutputStream::writeUnsigned(unsigned long long, bool)':
/home/buildslave/buildslave/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions/llvm/projects/libcxxabi/src/demangle/Utility.h:55: undefined reference to `__aeabi_uldivmod'
/home/buildslave/buildslave/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions/llvm/projects/libcxxabi/src/demangle/Utility.h:56: undefined reference to `__aeabi_uldivmod'
clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)

It seems after r371273 OutputStream is used more extensively and
is pulling OutputStream::writeUnsigned (which thus requires unsigned
integer module).

The straightfoward fix is to explicit link against libgcc if
compiler-rt is not used.

Fix gdb_pretty_printer_test on python3

First issue is the 'next' iteration method which has changed its
name to '_next_'.  The another is the division method, where it
requires to use the floor division so iteration converge.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67731

Files:
  libcxx/test/pretty_printers/gdb_pretty_printer_test.py
  libcxx/utils/gdb/libcxx/printers.py
  libcxxabi/cmake/config-ix.cmake
  libcxxabi/src/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67731.220740.patch
Type: text/x-patch
Size: 4727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190918/74765a1f/attachment.bin>