[PATCH] D67705: [mips] Expand 'lw/sw' instructions for 32-bit GOT
Petar Avramovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 18 08:30:03 PDT 2019
Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/test/MC/Mips/mips64-expansions.s:3
# RUN: -show-encoding | FileCheck --check-prefixes=CHECK,GOT %s
# Check that signed negative 32-bit immediates are loaded correctly:
----------------
Missing run line with -mattr=+xgot.
================
Comment at: llvm/test/MC/Mips/mips64-expansions.s:506
+
+# XGOT: ld $8, %got_disp(sym)($gp) # encoding: [A,A,0x88,0xdf]
+# XGOT-NEXT: # fixup A - offset: 0, value: %got_disp(sym), kind: fixup_Mips_GOT_DISP
----------------
Do symbols have different handling in assembly file based on something, like getAddrLocal and getAddrGlobal/getAddrGlobalLargeGOT in MipsISelLowering.cpp ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67705/new/
https://reviews.llvm.org/D67705
More information about the llvm-commits
mailing list