[PATCH] D62063: CMake changes to get Windows self-host with PGO working

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Sadly, this seems to break the lit tests on Mac when building with a profile.

Here's an attempt to do a bootstrap with PGO on Mac for Chromium: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901987169223158016/+/steps/package_clang/0/stdout

It ends with:

  [571/572] Running the LLVM regression tests
  llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/test/lit.site.cfg.py', traceback: Traceback (most recent call last):
    File "/b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
      exec(compile(data, path, 'exec'), cfg_globals, None)
    File "/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/test/lit.site.cfg.py", line 33
      config.host_ldflags = "-stdlib=libc++ -fno-pie -fprofile-instr-use="/b/s/w/ir/cache/builder/src/third_party/llvm-instrumented/profdata.prof""
                                                                                                                                                  ^
  SyntaxError: invalid syntax
  
  FAILED: test/CMakeFiles/check-llvm 

Maybe config.host_ldflags should be using single quotes? Or actually maybe that flag shouldn't end up in host_ldflags at all, though I'm not sure how one would fix that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62063/new/

https://reviews.llvm.org/D62063