[PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 18 06:03:09 PDT 2019
labath added a comment.
Unfortunately, there was a bug here which caused the test to fail on linux and windows. r372222 ought to fix that. From the patch description:
The test was expecting the value of "lldb.frame" to be None, because it
is cleared after each python interpreter session. However, this is not
true in the very first session, because lldb.py sets these values to
invalid objects (lldb.SBFrame(), etc.).
I have not investigated why is it that this test passes on darwin, but
my guess is that this is because we do extra work on darwin (loading the
objc runtime, etc), which causes us to enter the python interpreter
sooner.
This patch changes lldb.py to also initialize these values to None, as
that seems to make more sense.
I am pretty sure this will fix the issue on linux, but I am not sure about windows, because it may fail later due to the use of nested quotes, which mostly doesn't work there. Overall, it's usually better to avoid nested quotes in lit tests.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67685/new/
https://reviews.llvm.org/D67685
More information about the llvm-commits
mailing list