[PATCH] D67690: [LV][NFC] Factor out calculation of "best" estimated trip count.
Evgeniy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 18 04:54:21 PDT 2019
ebrevnov marked 2 inline comments as done.
ebrevnov added a comment.
Thanks Hideki & Ayal for quick response!
If you are satisfied with the current version please go ahead and commit it since I'm not permitted to do that myself.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:372
+ auto TC = getLoopEstimatedTripCount(L);
+ if (TC.hasValue())
+ return TC;
----------------
Ayal wrote:
> nit: can simply check `if (TC)`, or fold into
>
> ```
> if (Optional<unsigned> TC = getLoopEstimatedTripCount(L))
> return TC;
> ```
> as done above and below; possibly combining it with the previous if.
Thanks for noting. Done!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67690/new/
https://reviews.llvm.org/D67690
More information about the llvm-commits
mailing list