[PATCH] D67544: [TableGen] Support encoding and decoding per-HwMode

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 01:54:22 PDT 2019


jmolloy marked an inline comment as done.
jmolloy added a comment.

Thanks Krzysztof!



================
Comment at: llvm/utils/TableGen/SubtargetEmitter.cpp:1876
      << " const;\n";
   if (TGT.getHwModes().getNumModeIds() > 1)
     OS << "  unsigned getHwMode() const override;\n";
----------------
kparzysz wrote:
> This is probably unnecessary with your change.
Unfortunately it's still necessary, as TargetSubtargetInfo and MCSubtargetInfo are not related. We need HwModes in both (test failures bear this out).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67544/new/

https://reviews.llvm.org/D67544





More information about the llvm-commits mailing list