[PATCH] D67679: [SLC] Convert some strndup calls to strdup calls

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 22:33:15 PDT 2019


xbolva00 marked an inline comment as done.
xbolva00 added inline comments.


================
Comment at: test/Transforms/InstCombine/strndup.ll:21
+; CHECK-LABEL: @test2(
+; CHECK-NEXT:    [[RET:%.*]] = call i8* @strndup(i8* dereferenceable(6) getelementptr inbounds ([6 x i8], [6 x i8]* @hello, i64 0, i64 0), i32 4)
+; CHECK-NEXT:    ret i8* [[RET]]
----------------
jdoerfert wrote:
> Why don't we get a `dereferenceable_or_null(4)` here?
annotateAllocSite doesnt know about strndup yet :) follow-up patch will solve it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67679/new/

https://reviews.llvm.org/D67679





More information about the llvm-commits mailing list