[PATCH] D67656: [llvm-objcopy] Add --set-section-alignment

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:769
       getOutputElfType(Config.OutputArch.getValueOr(MachineInfo()));
   if (Error E = handleArgs(Config, *Obj, Reader, OutputElfType))
     return E;
----------------
jakehehrlich wrote:
> I'm confused, you still go though handleArgs here. Why do you need to handle this flag above?
They are not needed. handleArgs sets the alignment of the newly created `.data`. I don't know why I added the code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67656/new/

https://reviews.llvm.org/D67656