[PATCH] D66955: [DebugInfo][If-Converter] Update call site info during the optimization
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 17 11:27:53 PDT 2019
vsk added a comment.
Splitting up the updateCallSiteInfo API is a great idea. Some minor comments inline.
================
Comment at: include/llvm/CodeGen/MachineFunction.h:996
+ /// Move the call site info from \p Old to \New call site info. This function
+ /// is used when we are replacing one call instruction with the another one to
+ /// the same callee.
----------------
nit: s/the//
================
Comment at: include/llvm/CodeGen/MachineFunction.h:1001
+
+ /// Erase the call site info for \p MI. It is used when we are removing a call
+ /// instruction from the instruction stream.
----------------
nit: s/we are removing/to remove/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66955/new/
https://reviews.llvm.org/D66955
More information about the llvm-commits
mailing list