[PATCH] D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Looks reasonable to me, I just suggest clarifying one comment. @aprantl any other outstanding concerns?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:693
     // Create an entry value expression where the expression following
-    // the 'DW_OP_entry_value' will be the size of 1 (a register operation).
-    DIExpression *EntryExpr = DIExpression::get(MF->getFunction().getContext(),
-                                                {dwarf::DW_OP_entry_value, 1});
+    // the 'DW_OP_LLVM_entry_value' will be the size of 1 (a register
+    // operation).
----------------
-> "will contain 1 operation (e.g. a register op, or a constant literal)" ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67492/new/

https://reviews.llvm.org/D67492