[PATCH] D67561: [SampleFDO] minimize performance impact when profile-sample-accurate is enabled

[Wei Mi via Phabricator via llvm-commits]

wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: include/llvm/ProfileData/SampleProfReader.h:334
+  /// Get the pointer of name table which includes all the names used in
+  /// FunctionSamples.
+  virtual std::vector<StringRef> *getNameTable() { return nullptr; }
----------------
wmi wrote:
> davidxl wrote:
> > Make it clearer that it includes all the names that have samples either in outline instance or an inline instance. It is a subset of the symbol list of the binary.
> Will fix. 
Actually it is not a subset of symbol list of the binary. It is possible that a function is inlined everywhere and the outline instance gets deleted so it won't show up in the symbol list of the binary, but it will show up in the profile. 




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67561/new/

https://reviews.llvm.org/D67561