[PATCH] D67665: [ADT] Add 2 DenseMap::insert_or_assign overloads
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 17 09:34:22 PDT 2019
dexonsmith added inline comments.
================
Comment at: include/llvm/ADT/DenseMap.h:219-222
+ template <typename V>
+ std::pair<iterator, bool> insert_or_assign(const KeyT &Key, V &&Val) {
+ return insert_or_assign(Key, std::forward<V>(Val));
+ }
----------------
This looks accidentally recursive to me, and I don't see test coverage for it.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67665/new/
https://reviews.llvm.org/D67665
More information about the llvm-commits
mailing list