[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:92
+
+struct VFInfo;
+namespace VFABI {
----------------
Sorry, just spotting this now. Instead of having `struct VFInfo;` here, can you just move the definition of `VFInfo` here?


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:136
+    return VFABI::tryDemangleForVFABI(MangledName);
+    // if (OptPD.hasValue()) {
+    //   const VFABI::ParsedData PD = OptPD.getValue();
----------------
nit: this code is still commented out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024