[PATCH] D67449: [llvm-ar] Include a line number when failing to parse an MRI script

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/mri-errors.test:9
+RUN: not llvm-ar -M < %t/script1.mri 2>&1 | FileCheck --check-prefix=SCRIPT1 %s
+SCRIPT1: error: script line 2: Could not open library
+
----------------
jhenderson wrote:
> grimar wrote:
> > MaskRay wrote:
> > > A bit inconvenience for you (sorry!): after D67558, the error messages are no longer capitalized, so this needs a rebase.
> > > 
> > > If I recall correctly, one point raised by @grimar or @jhenderson before is that we should still use `# ` comment markers even if the test contains no code. I hope they can confirm.
> > Well, I also do not remember now, but I would be happy to see `##` as a comment marker everywhere in tests,
> > or at least at places where there are no markers.
> > @jhenderson, what do you think?
> I have no strong preference for `#` versus `##`, as long as we use one in tests which don't necessarily need them, as it makes the comments stand-out from the rest of the test (same reason for using `##` in tests that need `#` for RUN lines etc). If someone else has a preference to use `##` everywhere, that's fine with me.
Just to make the action item concrete,

`Test different ...` -> `## Test different ...`
`RUN:` -> `# RUN:`



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67449/new/

https://reviews.llvm.org/D67449