[PATCH] D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"

[Krasimir Georgiev via Phabricator via llvm-commits]

krasimir created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
krasimir added a reviewer: bkramer.
krasimir added a reviewer: xbolva00.

This reverts commit r372101.

Causes ASAN build bot failures:

http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176
>From http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176/steps/64-bit%20check-asan/logs/stdio:

  [ RUN      ] AddressSanitizer.StrNCatOOBTest
  /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/compiler-rt/lib/asan/tests/asan_str_test.cpp:462: Failure
  Death test: strncat(to - 1, from, 0)
      Result: failed to die.


Repository:
  rL LLVM

https://reviews.llvm.org/D67658

Files:
  lib/Transforms/Utils/SimplifyLibCalls.cpp
  test/Transforms/InstCombine/strncpy-1.ll


Index: test/Transforms/InstCombine/strncpy-1.ll
===================================================================
--- test/Transforms/InstCombine/strncpy-1.ll
+++ test/Transforms/InstCombine/strncpy-1.ll
@@ -134,16 +134,6 @@
   ret i8* %ret
 }
 
-define i8* @test3(i8* %dst, i32 %n) {
-; CHECK-LABEL: @test3(
-; CHECK-NEXT:    call void @llvm.memset.p0i8.i32(i8* noalias nonnull align 1 dereferenceable(5) [[DST:%.*]], i8 0, i32 5, i1 false)
-; CHECK-NEXT:    ret i8* [[DST]]
-;
-  %src = getelementptr [1 x i8], [1 x i8]* @null, i32 0, i32 0
-  %ret = call i8* @strncpy(i8* noalias nonnull %dst, i8* nonnull %src, i32 5);
-  ret i8* %ret
-}
-
 ; Check cases that shouldn't be simplified.
 
 define void @test_no_simplify1() {
Index: lib/Transforms/Utils/SimplifyLibCalls.cpp
===================================================================
--- lib/Transforms/Utils/SimplifyLibCalls.cpp
+++ lib/Transforms/Utils/SimplifyLibCalls.cpp
@@ -610,10 +610,7 @@
 
   if (SrcLen == 0) {
     // strncpy(x, "", y) -> memset(align 1 x, '\0', y)
-    CallInst *NewCI = B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1);
-    AttrBuilder ArgAttrs(CI->getAttributes().getParamAttributes(0));
-    NewCI->setAttributes(NewCI->getAttributes().addParamAttributes(
-        CI->getContext(), 0, ArgAttrs));
+    B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1);
     return Dst;
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67658.220495.patch
Type: text/x-patch
Size: 1366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190917/a3f0b228/attachment.bin>