[PATCH] D67652: [yaml2obj/obj2yam] - Allow setting an arbitrary values for e_machine.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two minor suggestions.



================
Comment at: test/tools/obj2yaml/elf-emachine.yaml:22
+
+## Check it dumps a known e_machine value as a enum string.
+
----------------
a enum -> an enum


================
Comment at: test/tools/yaml2obj/elf-emachine.yaml:1
+## Test how Machine property can be used to set e_machine field.
+
----------------
I'd rephrase this slightly:

"Test how the Machine YAML field can be used to set the e_machine ELF header field."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67652/new/

https://reviews.llvm.org/D67652