[PATCH] D67539: [ARM][LowOverheadLoops] Add LR def safety check

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.



================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:169
+  MachineInstr *PredLRDef =
+    SearchForDef<MachineBasicBlock::reverse_iterator>(Start, MBB->rend(),
+                                                      ARM::LR);
----------------
dmgreen wrote:
> Is the template type needed, or can it be left implicit?
I meant can it just be: MachineInstr *PredLRDef =SearchForDef(Start, MBB->rend(), ARM::LR), and it picks up the reverse_iterator automatically from the rend type. So SearchForDef is the same template, it's just that the template type is implicit from the args. I'm not sure if this will work or not (or if it's actually better!)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67539/new/

https://reviews.llvm.org/D67539