[PATCH] D67615: [obj2yaml] - Support PPC64 relocation types.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: lib/ObjectYAML/ELFYAML.cpp:657
   default:
     llvm_unreachable("Unsupported architecture");
   }
----------------
grimar wrote:
> jhenderson wrote:
> > This shouldn't be llvm_unreachable, since it is very reachable...
> > 
> > It should be, at most, an error instead (though arguably it should just do the enumFallback in that case).
> Well, probably yes. But this is original logic and also there is at least one more place with the same thing.
> Let me address this in a different patch.
Fair enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67615/new/

https://reviews.llvm.org/D67615