[PATCH] D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC.

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 02:49:16 PDT 2019


seiya added a comment.

Thanks you for feedbacks. Putting it all together, the @alexshap's suggestion (D67139#inline-607235 <https://reviews.llvm.org/D67139#inline-607235>) looks desirable to me because:

- It avoids verbose `Config.Common.Option` as @MaskRay pointed out in D67139#inline-607071 <https://reviews.llvm.org/D67139#inline-607071>.
- It supports a mixture of file formats as @jhenderson described in D67139#1671069 <https://reviews.llvm.org/D67139#1671069> without additional memory copies of CopyConfig.

I'll update the patch but comments are still welcome of course.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67139/new/

https://reviews.llvm.org/D67139





More information about the llvm-commits mailing list