[PATCH] D67615: [obj2yaml] - Add a support for PPC64 relocations.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, aside from a concern with the error case.



================
Comment at: lib/ObjectYAML/ELFYAML.cpp:657
   default:
     llvm_unreachable("Unsupported architecture");
   }
----------------
This shouldn't be llvm_unreachable, since it is very reachable...

It should be, at most, an error instead (though arguably it should just do the enumFallback in that case).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67615/new/

https://reviews.llvm.org/D67615