[PATCH] D67404: [ARM] LE support in ConstantIslands

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

In D67404#1672116 <https://reviews.llvm.org/D67404#1672116>, @samparker wrote:

> I'd say that it's sub-optimal... I don't know how often the issue will arise and whether that justifies using LoopInfo here. I'm also unsure how that extra logic would fit in with the current optimisation as we'd want to visit inner loops first, instead of walking backwards.


Yeah, I agree. I don't think it should cause too much trouble to have nested LE's, it would just invalidate the loop info on each outer iteration.

LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67404/new/

https://reviews.llvm.org/D67404