[PATCH] D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278).

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-stackmap-unsupported-version-2.test:1
+## Check that llvm-readobj/llvm-readelf reports a warning when parsing an unsupported stack map version.
+
----------------
It says you check `llvm-readelf`, but you don't. You might want to add it too.


================
Comment at: llvm/test/tools/llvm-readobj/elf-stackmap-unsupported-version-2.test:6
+
+# CHECK: stack map entry with version 2 detected at offset 0x0, which is not supported.
+
----------------
> stack map entry with version 2 detected at offset 0x0, which is not supported.

It is probably not that clear that "not supported" is not about "at offset 0x0", but about version?

Perhaps, the following is slightly better:
`stack map entry with unsupported version 2 detected at offset 0x0`

You also do not need a full stop in the message.
(Having it is inconsistent with the other ones we have in this tools I believe).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67328/new/

https://reviews.llvm.org/D67328