[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Mon Sep 16 21:34:38 PDT 2019

paulkirth added inline comments.

================
Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79
+  DK_FirstPluginKind,
+  DK_MisExpect
 };
----------------
jrtc27 wrote:
> Is this not going to clash with the first caller to `getNextAvailablePluginDiagnosticKind`? `DK_FirstPluginKind` is special and shouldn't have anything after it.
hmm, I wasn't aware of that. Is this documented somewhere? Also no tests seem to break from this, so that might be another area to address.

I'll upload a patch for this that moves the flag, and adds a note about the ordering.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324