[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:153
+      const VFABI::ParsedData PD = OptPD.getValue();
+      const VFShape Shape({PD.VF, PD.IsScalable, PD.ISA, PD.Parameters});
+      return VFInfo({Shape, PD.ScalarName, PD.VectorName});
----------------
sdesmalen wrote:
> Can't tryDemangleForVFABI return a `Optional<VFInfo>` directly? (rather than construct it here from the `ParsedData`)
> This also makes me question the need for `ParsedData`.
I could, but I think it is not the right thing to do. I expect the the`VFInfo` struct to grow beyond handling Vector Function ABI  and OpenMP information (it is one of the requirements). When this happens, all we need to do is just to to change this line adding a proper ParsedData -> VFInfo constructor instead of having to adapt the parser to the new VFInfo class.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024