[PATCH] D67622: [LLD][AARCH64] Small refactor of AArchErrataFix to match changes in ARMErrataFix NFC.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 16 09:51:35 PDT 2019
MaskRay added inline comments.
================
Comment at: ELF/AArch64ErrataFix.cpp:467
[=](const Defined *a, const Defined *b) {
- return (isCodeMapSymbol(a) && isCodeMapSymbol(b)) ||
- (isDataMapSymbol(a) && isDataMapSymbol(b));
+ return (isCodeMapSymbol(a) == isCodeMapSymbol(b));
}),
----------------
The outer `()` can probably be removed.
================
Comment at: ELF/AArch64ErrataFix.cpp:470
mapSyms.end());
+ // Always start with a Code Mapping Symbol
+ if (!mapSyms.empty() && !isCodeMapSymbol(mapSyms.front()))
----------------
Missing full stop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67622/new/
https://reviews.llvm.org/D67622
More information about the llvm-commits
mailing list