[PATCH] D67554: [docs][llvm-strings] Write llvm-strings documentation

[James Henderson via Phabricator via llvm-commits]

jhenderson marked 2 inline comments as done.
jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-strings.rst:16
+is intended as a drop-in replacement for GNU's :program:`strings`, although
+there are some differences.
+
----------------
MaskRay wrote:
> > although there are some differences.
> 
> I assume you mean `-a`. Other binary utilities have differences with their GNU binutils counterparts, I am just wondering why you raise this point specifically for llvm-strings.
> 
> 
> PS: Our behavior (always -a) conforms to POSIX:
> 
> > -a Scan files in their entirety. If -a is not specified, it is implementation-defined what portion of each file is scanned for strings.
It's related to -a, but more generally, llvm-strings dumps all strings in all files, regardless of file format. I guess this sentence isn't really necessary.


================
Comment at: llvm/docs/CommandGuide/llvm-strings.rst:107
+     609 main
+ $ llvm-strings --radix=x test.o
+     22c _Z5hellov
----------------
MaskRay wrote:
> Probably give an `-t x` example here.
Instead of or in addition to --radix=x?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67554/new/

https://reviews.llvm.org/D67554