[PATCH] D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 05:20:39 PDT 2019


samparker marked 2 inline comments as done.
samparker added inline comments.


================
Comment at: unittests/Target/ARM/MachineInstrTest.cpp:16
+// descriptions. Currently the horizontal vector operations are tagged.
+// TODO Add instructions that perform:
+// - truncation,
----------------
SjoerdMeijer wrote:
> Does this TODO mean we are currently allowing instructions that should not be allowed? If so, is that a problem?
We're not generating any TP loops yet, so we're okay! The approach will be to all the suspicious instructions here first so we don't have to test all of them when we finally implement the last part of predication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67444/new/

https://reviews.llvm.org/D67444





More information about the llvm-commits mailing list