[PATCH] D67482: [ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_X86_64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 15 23:49:01 PDT 2019


MaskRay marked 5 inline comments as done.
MaskRay added a comment.

Thanks for the math suggestion. Will push shortly. We should will get rid of the `bool enabled` variable in `Writer<ELFT>::fixSectionAlignments()`.



================
Comment at: test/ELF/x86-64-tls-ie.s:33
 
-// 0x201000 + 4281 + 7 = 0x2020C0
-// 0x20100A + 4279 + 7 = 0x2020C8
-// 0x201014 + 4269 + 7 = 0x2020C8
+// 0x2012d0 + 4329 + 7 = 0x2023C8
+// 0x2012dA + 4327 + 7 = 0x2023D0
----------------
grimar wrote:
> ```
> = 2023C0
> ```
It should be 0x2023C8. It is another use of tls0.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67482/new/

https://reviews.llvm.org/D67482





More information about the llvm-commits mailing list