[PATCH] D65408: [Attributor] Heap-To-Stack Conversion

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D65408#1670702 <https://reviews.llvm.org/D65408#1670702>, @xbolva00 wrote:

> Quite questionable is “stackification” of mallocs in loops, we should avoid it I think. @efriedma, what do you think?


Please can you be more specific?

In D65408#1670703 <https://reviews.llvm.org/D65408#1670703>, @xbolva00 wrote:

> IsMallocLikeFn returns true for C++ operator new which does throw on an allocation failure.


Likewise, please can you be more specific in your messages? This doesn't actually explain what the problem is.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65408/new/

https://reviews.llvm.org/D65408