[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added a comment.

In D67253#1670569 <https://reviews.llvm.org/D67253#1670569>, @lebedev.ri wrote:

> Layering feels weird here.
>  Can this be implemented as/limited to just a
>  `run-clang-misexpect.py` wrapper over clang itself?
>  That would be best IMHO.


I discussed the concurrency issue with some folks who work on libTooling, notably Sam McCall & Dmitri Gribenko. This was the approach they suggested I follow. LibTooling also provides some nice mechanisms for curating compiler options, which is possible, but less than ideal to reimplement in a python script. There are probably more benefits that escape me at the moment, but that was the first one I thought of.

Out of curiosity, if the concurrency issue was fixed in the compiler and the python script was removed/deprecated, would you still feel the same way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67253/new/

https://reviews.llvm.org/D67253