[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Alexandre Isoard via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 15 12:30:15 PDT 2019


I'm not sure what is the advantage of this compared to -Wpadded?

On Sun, Sep 15, 2019 at 12:05 PM Roman Lebedev via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> lebedev.ri added a comment.
>
> Forgot the most important question.
> Right now this will fire on every single struct.
> But it won't matter unless the alignment/size actually matters, and most
> often that will happen when you have e.g. a vector of such structs.
> What i'm asking is - should this be more picky, and complain only about
> the cases where this matters?
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D66564/new/
>
> https://reviews.llvm.org/D66564
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


-- 
*Alexandre Isoard*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190915/a8a87ef1/attachment.html>


More information about the llvm-commits mailing list